Improve CSP#1838
Open
HayimShaul wants to merge 11 commits into
Open
Conversation
Contributor
|
Hi @HayimShaul , thanks for this effort. It looks promising. Please, fix the errors reported by the CI so we can check if the tests are passing. Please, also run the benchmarks to understand which improvements this PR brings in. @neetance , you might be interested in having a look at this as well. Thanks 🙏 |
HayimShaul
force-pushed
the
hayim_temp_jun25
branch
from
b5691c0 to
4bf946f
Compare
Contributor
|
Hi @HayimShaul , please, run the benchmark with and without the optimization to see what's the gain. Please, post the result here. Thanks 🙏 |
Contributor
|
@HayimShaul could you please open an issue and attached it to this PR. Please put the issue under the generic EPIC. |
Signed-off-by: Hayim Shaul <hayim.shaul@gmail.com>
Signed-off-by: Hayim Shaul <hayim.shaul@gmail.com>
Signed-off-by: Hayim Shaul <hayim.shaul@gmail.com>
Signed-off-by: Hayim Shaul <hayim.shaul@gmail.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
HayimShaul
force-pushed
the
hayim_temp_jun25
branch
from
0c16070 to
f1f90f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the CSP ZKP
co-authored with: @kushnireyal